Skip to content

feat: Add job: Rebase Pull Requests#3642

Merged
mrCherry97 merged 39 commits intokyma-project:mainfrom
akucharska:gh-actions-rebase
Feb 6, 2025
Merged

feat: Add job: Rebase Pull Requests#3642
mrCherry97 merged 39 commits intokyma-project:mainfrom
akucharska:gh-actions-rebase

Conversation

@akucharska
Copy link
Contributor

@akucharska akucharska commented Jan 29, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Add rebase step in jobs that are building Busola

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2025
@akucharska
Copy link
Contributor Author

akucharska commented Jan 29, 2025

/hold

@kyma-bot kyma-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2025
@akucharska akucharska linked an issue Jan 29, 2025 that may be closed by this pull request
Rebase script for Github Action workflows #3628
Closed
6 tasks
@akucharska akucharska requested a review from a team as a code owner January 29, 2025 10:02
akucharska
akucharska commented Jan 29, 2025
View reviewed changes
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2025
dbadura
dbadura requested changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@dbadura dbadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add rebase to build jobs.

.github/workflows/pull-integration-cluster-k3d.yml
comment_on_pr: false
- uses: actions/checkout@v4
# - uses: ./.github/actions/rebase
with:
Copy link
Contributor

@dbadura dbadura Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can add name

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 6, 2025
@mrCherry97 mrCherry97 added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 6, 2025
@mrCherry97 mrCherry97 merged commit dabfa47 into kyma-project:main Feb 6, 2025
17 checks passed
@mrCherry97 mrCherry97 deleted the gh-actions-rebase branch February 6, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbadura dbadura dbadura approved these changes

@KonradPietocha KonradPietocha KonradPietocha approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@dbadura dbadura

@KonradPietocha KonradPietocha

Labels

cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rebase script for Github Action workflows

5 participants

@akucharska @dbadura @KonradPietocha @kyma-bot @mrCherry97